-
Notifications
You must be signed in to change notification settings - Fork 1
Add error message for contractor with no contracts related to trade #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlexpdHackney
wants to merge
13
commits into
develop
Choose a base branch
from
contractor-with-no-trade-contracts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merge pull request #1238 from LBHackney-IT/callum/trigger-dev-redeployment Random change to trigger new dev deployment * Move contracts dashboard (#1236) * add contracts dashboard to header * take contracts dashboard out of back office * move contractor page out of back office * change url for tests * change urls in tests * remove contracts dashboard from backoffice * fix test * remove .only * set yesterday differently * move request functions to contracts dashboard * move from back office * fix tests * remove .only * move request functions into requests folder * fix path * fix path * remove contracts dashboard link * remove redundant question marks * change check of isActive * fix intercept paths * fix path * Improvements to Repairs Finder Form (#1237) * Add link to repairs finder * Move logic to hook * Display priority description * Populate description * Remove description field * fix type error * Extract spend limit logic * get validation working longside the form * lf * Add most cypress tests * Update yarn * LF * Cleanup * Cleanup property flags * Refactor * lf * Update tests * RM budget code logic from tests * Remove followon logic * Update unit tests * Update yarn.lock * Reset yarn lock file * LF * Update unit tests * Intercept FT for e2e tests * Fix * try with resouce name * More updates * revert unit tests * cleanup * Fix syntax * Refactor + unit tests * Add basic property contract error * Add unit tests * Add more unit tests * Fix unit tests * Tidy * cleanup * Repairs finder form UI updates (#1240) * Update raise workOrder linsk, and use hardcoded env * Remove info box from raise work order page * Refactor repairs finder info box * Move repairs finder link to ENV * env.local.sample * Update snapshots * Update E2E tests * LF * Update snapshots * Update E2E tests with FT enabled * Fix format * Add contract admin user group (#1239) * add contract admin user group * change from data to contract admin permissions * check test passes * check if passes * save * revert * push to retrigger * remove .only * troubleshoot * reinstate * log cypress cookie * change from data to contract * remove cy.log (#1244) * Merge pull request #1245 from LBHackney-IT/callum/fix-repairs-finder-comments Fix repairs finder comments --------- Co-authored-by: AlexpdHackney <[email protected]> Co-authored-by: Adam <[email protected]> Co-authored-by: acanbym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
A brief description of the change, with enough context for the reviewer to be able to understand why we're making this change.
Story Link
https://link-to-issue
Automated test checklist
If a type of test isn't included, add note explaining why.
Decisions [OPTIONAL]
If you had to make any decisions between different ways of doing things, what where they and why?
Known issues [OPTIONAL]
Things you know need further follow on work but aren't in scope of this issue