-
Notifications
You must be signed in to change notification settings - Fork 25
Qurrency implementation #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Adds circom circuits to prove knowledge of the message and randomness used to create an ML-KEM ciphertext
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Signed-off-by: Guru Vamsi Policharla <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Starting point for introducing Qurrency-based Auditing in Zeto
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
|
I've reviewed this PR: all tests pass. In addition to the tests, there are a few more compelling indicators of correctness:
Following this PR, it'd be good to (1) accompany these implementations with additions to the documentation describing the security properties achieved, and (2) write integration tests for the Qurrency tokens. Since these tokens only have unit tests, they aren't yet tested in this repo's GitHub workflow. |
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just a few code sanity comments
Signed-off-by: Jim Zhang <[email protected]>
Chengxuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick scan.
There are some TODO comments worth validating, and the copyright headers of new files should be 2025.
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
This is the initial implementation for the Qurrency protocol (details to be announced soon).
Circuits
Token Implementation
anon_nullifier_qurrency.sol. It includes thetransfer()method enhanced to include the ciphertext and using the new proof verifier for the new circuit above, including the regular 2x2 circuit and the batch circuitTODO: see #133