Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a macro defining the maximum length of resource names. I would have preferred a constant of type size_t, but everything else in this file is a macro, so I used one too for consistency.
There did not seem to be any explicit limit on the length of resource names in the kernel module, other than whatever space is left in the netlink messages for the corresponding field (but I did not search too thorougly, so maybe I'm wrong...).
Anyhow, this explicit limit of 127 bytes is the de facto limit of the new-resource command in the drbdsetup utility, since any longer name causes a failed assertion in drbdsetup.
As a result, it should be reasonably safe to conclude that longer names are not used in production anywhere, and establishing an explicit limit of 127 bytes in the kernel module will not break any existing installations.