Skip to content

Laghos comm cali #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 43 commits into from
Closed

Laghos comm cali #316

wants to merge 43 commits into from

Conversation

gracenansamba
Copy link
Collaborator

@gracenansamba gracenansamba commented Jul 22, 2024

Description

Here is the Laghos branch plus the changes I made.
I made changes in repo/mfem, and experiments/laghos/mpi/ramble.yaml

I have attached a link to mfem: https://github.com/gracenansamba/mfem.git

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added experiment New or modified experiment system New or modified system config labels Jul 22, 2024
"cce": "cray",
"gcc": "gnu",
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
variant("caliper", default=False, description="Build Caliper support")
def get_make_config_options(self, spec, prefix):
def yes_no(varstr):
return "YES" if varstr in self.spec else "NO"
options = super(Mfem, self).get_make_config_options(spec, prefix)
caliper_opt = ["MFEM_USE_CALIPER=%s" % yes_no("+caliper"), ]
return options + caliper_opt

@@ -15,6 +15,7 @@ compilers:
cflags: -g -O2
cxxflags: -g -O2 -std=c++17
fflags: -g -O2 -hnopattern
ldflags: {"-ldl"}
Copy link
Collaborator

@rfhaque rfhaque Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 @gracenansamba Had to add ldflags to get laghos running on tioga. The code runs on ruby, lassen and tioga in the mpi mode

Grace Nansamba and others added 3 commits September 6, 2024 16:19
@pearce8 pearce8 added the WIP A work-in-progress not yet ready to commit label Sep 27, 2024
@pearce8 pearce8 marked this pull request as draft December 10, 2024 17:01
@pearce8
Copy link
Collaborator

pearce8 commented Feb 17, 2025

@gracenansamba @dyokelson Has this been re-done using the dynamic system+experiment? Should we close this PR? Which PR replaces it?

@gracenansamba
Copy link
Collaborator Author

yes, Laghos has been redone and can eb replaced with
Laghos_Comm_dynamic

@pearce8
Copy link
Collaborator

pearce8 commented Feb 19, 2025

Superseded by #604.

@pearce8 pearce8 closed this Feb 19, 2025
@pearce8 pearce8 deleted the laghos_comm_cali branch March 22, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment New or modified experiment system New or modified system config WIP A work-in-progress not yet ready to commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants