Skip to content

[WIP] Mpi-Pingpong Benchmark #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from
Draft

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Apr 7, 2025

Description

  • todo:
    • Figure out how to pass location of pingpong directory (since private repo) on command line, instead of hard coding
    • Set trials using ramble n_repeats
    • Set number of nodes instead of setting total ranks per machine
    • Set required variables for benchpark analyze
      self.set_required_variables(
      n_resources="{npx}*{npy}*{npz}",
      process_problem_size="{nzx}*{nzy}*{nzz}/({npx}*{npy}*{npz})",
      total_problem_size="{nzx}*{nzy}*{nzz}",
      )

@michaelmckinsey1 michaelmckinsey1 changed the title Mpi-Pingpong Benchmark [WIP] Mpi-Pingpong Benchmark Apr 8, 2025

class MpiPingpong(CMakePackage):

git = "/usr/WS1/mckinsey/benchpark/mpi-pingpong/"
Copy link
Collaborator Author

@michaelmckinsey1 michaelmckinsey1 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to set this path dynamically? Can we do it like a ramble variable, e.g. {local_path}. I tried a relative path but it did not work ./mpi-pingpong/ or mpi-pingpong/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use #620 for this.

@github-actions github-actions bot added the system New or modified system config label Apr 30, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this May 2, 2025
@michaelmckinsey1
Copy link
Collaborator Author

Running trials in the same allocation parameter (ramble) https://ramble.readthedocs.io/en/latest/workspace_config.html#experiment-repeats

maintainers("stephanielam3211")

def compute_applications_section(self):
n_ranks = 448 #dane:896, ruby:448, tioga:512, lassen:352, tuolumne:768
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set this in terms of nodes 8, so we don't have to specify this for each machine. However the affinity output will look different, so we need to figure this out.

@github-actions github-actions bot added the feature New feature or request label Jun 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@michaelmckinsey1
Copy link
Collaborator Author

This benchmark will need the builtin-caliper tag from #888 once that is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application experiment New or modified experiment feature New feature or request system New or modified system config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants