Skip to content

[WIP] Standard Hwloc Configs #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amroakmal
Copy link
Collaborator

Resolves #809

@amroakmal amroakmal self-assigned this Jun 5, 2025
@amroakmal amroakmal added feature New feature or request WIP A work-in-progress not yet ready to commit labels Jun 5, 2025
@github-actions github-actions bot added docs Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Jun 5, 2025
@amroakmal amroakmal force-pushed the 809-standard-hwloc-configs branch from e9be741 to 6931b42 Compare June 5, 2025 22:09
@amroakmal amroakmal closed this Jun 10, 2025
@amroakmal amroakmal force-pushed the 809-standard-hwloc-configs branch from 6931b42 to 2fa8852 Compare June 10, 2025 16:26
@amroakmal amroakmal reopened this Jun 11, 2025
@michaelmckinsey1
Copy link
Collaborator

Can we refactor

class HwlocVariantValues(str, Enum):
    NONE = "none"
    ON = "on"

into

    variant(
        "hwloc",
        default=HwlocVariantValues.NONE.value,
        values=tuple(v.value for v in HwlocVariantValues),
        multi=False,
        description="Get underlying infrastructure topology",
    )

so it is the similar to the Affinity and SingleNode classes? I did not catch this in the last PR, but for consistency I think they should work the same.

@amroakmal
Copy link
Collaborator Author

@michaelmckinsey1 : Yes, sure. I thought this is cleaner and safer honestly, and more maintainable, so to not miss any value by a typo. Do you think better to stick old behavior? Or better adopt the Enum to other modifiers so all be on consistent and safer to deal with?

Thanks so much for bringing this up.

@amroakmal
Copy link
Collaborator Author

Self reminder: Improve variable names of the HWLOC class in experiment.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docs Improvements or additions to documentation feature New feature or request WIP A work-in-progress not yet ready to commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide standard configs from hwloc for pre-defined analysis
2 participants