Skip to content

remove det.cpp include in mfem #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jul 4, 2025

This PR removes the explicit copy of the missing include in mfem that used by remhos.
Fixes #852, follow up to #770

This PR can be merged once

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.

@rfhaque rfhaque requested a review from pearce8 July 4, 2025 08:26
@rfhaque rfhaque changed the title Remove redundant mfem include Remove explicit mfem include Jul 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.40%. Comparing base (cae351f) to head (f5d2757).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #871   +/-   ##
========================================
  Coverage    41.40%   41.40%           
========================================
  Files           22       22           
  Lines         1512     1512           
  Branches       214      214           
========================================
  Hits           626      626           
  Misses         841      841           
  Partials        45       45           
Flag Coverage Δ
unittests 41.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfhaque rfhaque changed the title Remove explicit mfem include remove det.cpp include in mfem Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remhos: Clean up after merges
2 participants