Skip to content

Update Nightly Testing Suite #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Update Nightly Testing Suite #892

wants to merge 9 commits into from

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jul 11, 2025

Description

  • Proposal: nightly tests should be mainly focus on testing as many benchmarks as possible once on each programming model (pick most important machine, e.g. test on tuolumne over tioga). Daily tests can cover testing of modifiers and scaling (testing gpumodes on MI300A are an exception). Reasoning: nightly tests dashboard when testing in this way is a useful to check which benchmarks are working/not working. Daily tests on PRs can check changes to benchpark library.
  • Depends on Post Nightly Tests to Correct Dashboard #894
  • Add more benchmarks to nightly test (-gromacs, -quicksilver, -saxpy)
    • rocm
    • mpi-only
    • cuda
    • openmp
  • rm other tests (except tpx/cpx mode) which can be covered in daily
  • Fix nightly TPX CPX tests, which were not allocating the node properly

Note: The bottleneck for increasing testing should be Dane, as we test mpi-only and openmp tests all on dane.

Adding/modifying core functionality, CI, or documentation:

  • Update .gitlab/tests/nightly.yml

@michaelmckinsey1 michaelmckinsey1 changed the title At6 nightly [WIP] nightly testing Jul 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.48%. Comparing base (5ac8be9) to head (46c34fe).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #892   +/-   ##
========================================
  Coverage    41.48%   41.48%           
========================================
  Files           22       22           
  Lines         1509     1509           
  Branches       213      213           
========================================
  Hits           626      626           
  Misses         838      838           
  Partials        45       45           
Flag Coverage Δ
unittests 41.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review July 11, 2025 21:10
Comment on lines 100 to 116
# - HOST: tuolumne
# ARCHCONFIG: llnl-elcapitan
# SCHEDULER_PARAMETERS: $ELCAP_PARAMS
# BENCHMARK: [amg2023, kripke, laghos, remhos]
# VARIANT: [+rocm caliper=mpi scaling=strong]
# - HOST: dane
# ARCHCONFIG: llnl-cluster
# SCHEDULER_PARAMETERS: $DANE_PARAMS
# BENCHMARK: [laghos, remhos]
# VARIANT: [caliper=mpi scaling=strong]
# - HOST: dane
# ARCHCONFIG: llnl-cluster
# SCHEDULER_PARAMETERS: $DANE_PARAMS
# BENCHMARK: [amg2023, kripke]
# VARIANT:
# - caliper=mpi scaling=strong
# - caliper=mpi scaling=weak
Copy link
Collaborator Author

@michaelmckinsey1 michaelmckinsey1 Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing these use cases should be handled in daily tests.

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 14, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] nightly testing [WIP] Update Nightly Testing Suite Jul 14, 2025
@michaelmckinsey1 michaelmckinsey1 changed the title [WIP] Update Nightly Testing Suite Update Nightly Testing Suite Jul 16, 2025
@michaelmckinsey1 michaelmckinsey1 added the ready for review Ready for review label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants