Skip to content

Analyze: Handle Case Where Name is None and New Intersection Option #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jul 14, 2025

Description

  • Currently, if profiles contain any different regions benchpark analyze will fail with error:
    return lib.map_infer(values, mapper, convert=convert)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "pandas/_libs/lib.pyx", line 2999, in pandas._libs.lib.map_infer
  File "/Users/mckinsey1/Documents/repos/benchpark/lib/benchpark/cmd/analyze.py", line 232, in <lambda>
    ".", lambda row: row["name"].apply(lambda n: "MPI_" not in n).all()
                                                 ^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

because of the check in the Thicket Query. Modifiying the check to not check against None fixes this issue

  • Additionally, add the option to take the intersection of the calltree instead of the union which is an alternative way to address this issue, but also a feature.

Adding/modifying core functionality, CI, or documentation:

  • Update `lib/benchpark/cmd/analyze.py

@github-actions github-actions bot added the feature New feature or request label Jul 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.40%. Comparing base (cae351f) to head (b5e8df3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #898   +/-   ##
========================================
  Coverage    41.40%   41.40%           
========================================
  Files           22       22           
  Lines         1512     1512           
  Branches       214      214           
========================================
  Hits           626      626           
  Misses         841      841           
  Partials        45       45           
Flag Coverage Δ
unittests 41.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelmckinsey1 michaelmckinsey1 changed the title Add intersection option and handle none Analyze: Handle Case Where Name is None and New Intersection Option Jul 14, 2025
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 14, 2025
@michaelmckinsey1 michaelmckinsey1 added the ready for review Ready for review label Jul 14, 2025
@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Jul 14, 2025

Make sure gitlab unit test for analyze passing (good if all dane tests passing) ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants