Add rocm 6.4 as the default rocm version on tuolumne #908
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #908 +/- ##
===========================================
+ Coverage 40.30% 41.26% +0.96%
===========================================
Files 15 22 +7
Lines 1119 1517 +398
Branches 152 215 +63
===========================================
+ Hits 451 626 +175
- Misses 632 846 +214
- Partials 36 45 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Waiting to see tuolumne/tioga tests |
pearce8
reviewed
Jul 21, 2025
systems/llnl-elcapitan/system.py
Outdated
| default="6.2.4", | ||
| values=("5.7.1", "6.2.4", "6.3.1"), | ||
| default="6.4.0", | ||
| values=("5.7.1", "6.2.4", "6.3.1", "6.4.0"), |
There was a problem hiding this comment.
Please add 6.4.1 as an option @rfhaque.
michaelmckinsey1
previously approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add rocm 6.4 as the default rocm version on tuolumne
Adding/modifying a system (docs: Adding a System)
systems/system_name/system.pyfile