Fix space-time sampling #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does "docs/readthedocs.org:librom" test fail? |
dreamer2368
approved these changes
Jun 24, 2024
siuwuncheung
approved these changes
Jun 24, 2024
|
readthedocs has the following error, which I don't understand. It is referring to the latest commit in this PR. @ckendrick do you have any ideas? git checkout --force e899ef1 |
|
@dylan-copeland I'm not sure why the docs build failed here. The log seems to show it was able to clone the repo and fetch the branch correctly. Maybe try pushing an empty commit or merging/rebasing this branch on master to kick off the build again and we can see if it still fails or not. |
|
Thanks @ckendrick, the tests passed after pulling from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 274 made the temporal basis non-distributed. This PR fixes a check so that space-time ROM works in Laghos.