Skip to content

Run lengthier examples in nightly CI #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

Run lengthier examples in nightly CI #1400

wants to merge 32 commits into from

Conversation

chapman39
Copy link
Collaborator

@chapman39 chapman39 commented Jun 5, 2025 •
edited
Loading

This PR...

  • move example tests away from on-push and to nightly CI. (Motivation is we should run these examples in full, but they take too long to justify running every commit.) Fixes Nightly Example CI Testing #1393
  • rename existing "full" to "tpl" (runs every night at 10pm)
  • create new nightly schedule "examples" (runs every night at 2am)
  • create run_examples CMake custom target, rather than having to run all unit tests. (works very similar to run_benchmarks
  • reduce github actions ci time limit back to 30 minutes
  • add toss4 clang 16 (enzyme) tpl ci job
  • fix blueos tpl ci job
  • increase blueos tpl build time Fixes blueos full still timing out #1293
  • disable testing docs on lassen ci, since it takes a very long time for some reason

TODO Before Merge

CI Demonstration

@chapman39 chapman39 self-assigned this Jun 5, 2025
@chapman39 chapman39 added the CI Continuous Integration label Jun 5, 2025
@tupek2 tupek2 self-requested a review June 5, 2025 17:55
chapman39
chapman39 commented Jun 9, 2025
View reviewed changes
.gitlab/build_toss4.yml
@@ -3,6 +3,7 @@
.on_toss4:
variables:
SCHEDULER_PARAMETERS: "--reservation=ci --exclusive=user --deadline=now+${ALLOC_DEADLINE}minutes -N ${ALLOC_NODES} -t ${ALLOC_TIME} -A ${ALLOC_BANK}"
ALLOC_DEADLINE: "180"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to give each job 3 hours deadline, since that matches what gitlab enforces for our project (see "Timeout"):

Screenshot 2025-06-09 at 11 28 01 AM

chapman39
chapman39 commented Jun 10, 2025
View reviewed changes
.gitlab/build_blueos.yml Outdated
EXTRA_CMAKE_OPTIONS: "-DENABLE_BENCHMARKS=ON -DENABLE_DOCS=OFF"
ALLOC_NODES: "1"
ALLOC_TIME: "65"
extends: [.full_build_on_blueos, .with_cuda]
ALLOC_TIME: "180"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO revert this or set to less ridiculous number

chapman39
chapman39 commented Jun 10, 2025
View reviewed changes
cmake/serac-config.cmake.in
else()
find_package(CUDAToolkit REQUIRED)
endif()
endif()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDAToolkit is now always required with CUDA, to find cublasLt

https://github.com/LLNL/serac/blob/develop/cmake/thirdparty/SetupSeracThirdParty.cmake#L44-L47

@chapman39 chapman39 marked this pull request as ready for review June 13, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupek2 tupek2 Awaiting requested review from tupek2

@white238 white238 Awaiting requested review from white238

@btalamini btalamini Awaiting requested review from btalamini

At least 2 approving reviews are required to merge this pull request.

Assignees

@chapman39 chapman39

Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Example CI Testing blueos full still timing out
2 participants
@chapman39 @tupek2