Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/operator splitting #572

Open
wants to merge 209 commits into
base: feature/sunstepper
Choose a base branch
from
Open

Feature/operator splitting #572

wants to merge 209 commits into from
+9,647 −139

Conversation

Steven-Roberts
Copy link
Collaborator

No description provided.

@Steven-Roberts
Initial commit after rebase
5f8ff59
@Steven-Roberts
Merge branch 'develop' into feature/operator-splitting
dadf074
@Steven-Roberts
Bug fixes for coefficients
9603515
@Steven-Roberts
Merge branch 'develop' into feature/operator-splitting
8d95da0
@Steven-Roberts
Finish splitting coefficient tests
4e39e52
@Steven-Roberts
Add mathematical description to docs
280d369
@Steven-Roberts
Add missing execution policy files
663a7ae
@Steven-Roberts
Template SplittingStep docs
8e5c5f0
@Steven-Roberts
Merge branch 'feature/sunstepper' into feature/operator-splitting
fd1fc7b
@Steven-Roberts
Rename to SplittingStepCoefficients
bede6b5
@Steven-Roberts
Merge branch 'feature/sunstepper' into feature/operator-splitting
3c0d6ff
@Steven-Roberts
Finish ADR example
19724c5
@Steven-Roberts
Finish ADR example
ac92708
@Steven-Roberts
Add another example
d72be79
@Steven-Roberts
Add 3rd order Suzuki method
cb039ea
@Steven-Roberts
3rd order Suzuki bug fix
08ba24b
@Steven-Roberts
Add skeleton docs
eacb38e
@Steven-Roberts
Add missing CMake file
3ad9763
@Steven-Roberts
Merge branch 'feature/sunstepper' into feature/operator-splitting
24de70f
@Steven-Roberts
Finish coefficient docs
a77f989
@Steven-Roberts
Clear up execution policy structure
082e5ee
@Steven-Roberts
Make helper function for default integrator
a3dfce7
@Steven-Roberts
Add splitting step comments
2255ff8
@Steven-Roberts
Comments in analytic splitting example
4a7bd60
@Steven-Roberts
Fix default coefficients bug
b812411
@Steven-Roberts
Add docs for execution policy
9e93ffe
@Steven-Roberts
Add coefficient ids to docs
4267f4a
@Steven-Roberts
Apply formatter
fe44bdf
@Steven-Roberts
Bring over forced splitting method
1485fc4
@Steven-Roberts
Add cli to ark analytic partitioned
7bd615c
gardner48
gardner48 requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments. One general point that came up is we should be careful not to over use const when it does provide meaningful protection.

doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Mathematics.rst Outdated Show resolved Hide resolved
test/unit_tests/arkode/CXX_serial/ark_test_splittingstep.cpp Outdated Show resolved Hide resolved
test/unit_tests/arkode/CXX_serial/ark_test_splittingstep.cpp Show resolved Hide resolved
test/unit_tests/arkode/C_serial/ark_test_forcingstep.c Outdated Show resolved Hide resolved
test/unit_tests/arkode/C_serial/ark_test_forcingstep.c Outdated Show resolved Hide resolved
test/unit_tests/arkode/C_serial/ark_test_forcingstep.c Outdated Show resolved Hide resolved
Steven-Roberts and others added 29 commits November 12, 2024 08:06
@Steven-Roberts
Fix stage indexing in docs
f7978bd
@Steven-Roberts
Fix equation for parallel splitting
1562d1b
@Steven-Roberts @gardner48
Apply simple doc fixes from code review
593df5e 
Co-authored-by: David Gardner <[email protected]>
@Steven-Roberts
Merge branch 'feature/operator-splitting' of github.com:LLNL/sundials…
2bac649 
… into feature/operator-splitting
@Steven-Roberts @gardner48
Apply simple src fixes
8ab2aa8 
Co-authored-by: David Gardner <[email protected]>
@Steven-Roberts @gardner48
Apply suggestions for PDE formulation comment
f2a73cd 
Co-authored-by: David Gardner <[email protected]>
@Steven-Roberts @gardner48
Apply simple fixes for unit tests from code review
e61e6d2 
Co-authored-by: David Gardner <[email protected]>
@Steven-Roberts
Merge branch 'feature/operator-splitting' of github.com:LLNL/sundials…
a410eaa 
… into feature/operator-splitting
@Steven-Roberts
SplittingStepCoefficients_Free to SplittingStepCoefficients_Destroy
ab6c699
@Steven-Roberts
Move initialization of beta to avoid memory leak
2b4a8e6
@Steven-Roberts
Make splittingstep skeleton not particular to ARKStep
b9d04ba
@Steven-Roberts
Remove inner and outer terms
7748696
@Steven-Roberts
Remove unnecessary headers
192cc48
@Steven-Roberts
Merge branch 'feature/sunstepper' into feature/operator-splitting
35dcc91
@Steven-Roberts
Mention splitting and forcing method in SUNStepper docs
4a93d50
@Steven-Roberts
Update beta to be 1 indexed for stages
9ea4ef4
@Steven-Roberts
Add Lie-Trotter and Strang examples to math considerations
9848af8
@Steven-Roberts
Remove inner and outer terms from docs
1accd45
@Steven-Roberts
Add missing subscripts to time step
d05b9c2
@Steven-Roberts
Fix header level
d148f2e
@Steven-Roberts
Move note for SplittingStepCoefficients_Write into param description
0bc2b30
@Steven-Roberts
Forward declare static functions in examples
dab105a
@Steven-Roberts
Remove const from examples
fd75720
@Steven-Roberts
Clarify step sizes in analytic partitioned example
fea95c9
@Steven-Roberts
Use ERKStep for ark_analytic_partitioned example
bba4fac
@Steven-Roberts
Remove const from tests
7f862d3
@Steven-Roberts
Remove const from forcingstep
85302fd
@Steven-Roberts
Remove const from splittingstep
f063740
@Steven-Roberts
Fix splittingstep failure after switching to ERKStep
544f25a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 requested changes

@drreynolds drreynolds drreynolds requested changes

@balos1 balos1 balos1 approved these changes

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Assignees
No one assigned
Labels
new-module pkg-ARKODE
Projects
None yet
Milestone
SUNDIALS Next
Development

Successfully merging this pull request may close these issues.
5 participants
@Steven-Roberts @drreynolds @balos1 @cswoodward @gardner48