Skip to content

CMake: add C23 option #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

CMake: add C23 option #780

merged 2 commits into from
Oct 7, 2025

Conversation

gardner48
Copy link
Member

Add C23 option to CMAKE_C_STANDARD

drreynolds
drreynolds approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have we confirmed that SUNDIALS can build without issue in C23?

@gardner48
Copy link
Member Author

gardner48 commented Oct 6, 2025 •
edited
Loading

Have we confirmed that SUNDIALS can build without issue in C23?

It works with gcc 15 (C23 became the default in gcc 15). I don't think other compilers have full C23 support yet.

@gardner48 gardner48 merged commit 1abfc1d into develop Oct 7, 2025
49 checks passed
@gardner48 gardner48 deleted the cmake/c23-option branch October 7, 2025 06:12
@gardner48 gardner48 added this to the SUNDIALS Next milestone Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balos1 balos1 balos1 approved these changes

@drreynolds drreynolds drreynolds approved these changes

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

SUNDIALS Next

Development

Successfully merging this pull request may close these issues.

3 participants

@gardner48 @balos1 @drreynolds