Skip to content

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Oct 7, 2025

No description provided.

@gardner48 gardner48 added this to the SUNDIALS Next milestone Oct 8, 2025
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be ideal if this error could have been caught by an example or unit test.

@gardner48 gardner48 merged commit a38802e into develop Oct 8, 2025
47 of 50 checks passed
@gardner48 gardner48 deleted the bugfix/sunstepper-reset-checkpoint branch October 8, 2025 15:46
@balos1
Copy link
Member Author

balos1 commented Oct 9, 2025

It would be ideal if this error could have been caught by an example or unit test.

Any example will also provide the Reset function, which is why it was not caught. We would have to start adding much more granular unit tests to catch these types of bugs (which I am all for as long as we commit to using googletest for them so the boiler plate is less).

I actually caught it through smoke tests I am setting up in the Python branch to make sure that user-supplied functions are being handled properly. The smoke test just creates a SUNStepper and then sets only one of the user-supplied functions at a time, and checks to see if it is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants