Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document spack_packages_path #131

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Document spack_packages_path #131

merged 5 commits into from
Mar 13, 2024

Conversation

white238
Copy link
Member

@white238 white238 commented Mar 13, 2024 •
edited
Loading

Plus small cleanups

  • copyrights
  • toss3 deletion
  • fixing the RTD build

https://uberenv.readthedocs.io/en/task-white238-document_package_repo/#project-configuration

Fixes #130

chapman39
chapman39 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@chapman39 chapman39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mentioning the priority of the Spack packages is helpful as I often forget the order.

@white238 white238 merged commit cf91883 into main Mar 13, 2024
8 checks passed
@white238 white238 deleted the task/white238/document_package_repo branch March 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapman39 chapman39 chapman39 approved these changes

@cyrush cyrush Awaiting requested review from cyrush

@kennyweiss kennyweiss Awaiting requested review from kennyweiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple package repos?
2 participants
@white238 @chapman39