Skip to content

Remove GUI menu items for global automation #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove GUI menu items for global automation #5230

wants to merge 2 commits into from
+0 −29

Conversation

Veratil
Copy link
Contributor

@Veratil Veratil commented Oct 7, 2019 •
edited
Loading

Completes step 3 from #403 BLOCKED BY #5229

This should be the only place where the GUI mentions and adds global automation menu items.

@LmmsBot
Copy link

LmmsBot commented Oct 7, 2019 •
edited
Loading

Downloads for this pull request

Generated by the LMMS pull requests bot.
SHA: 41bfc84

@tresf
Copy link
Member

tresf commented Nov 15, 2019

@Veratil until #5229 is merged, this really shouldn't be, right? Because we risk the chance that there's a track with one we can't remove? If this statement is true, can you adjust your PR to explain that this is blocked by #5229?

@Veratil
Copy link
Contributor Author

Veratil commented Nov 15, 2019

@Veratil until #5229 is merged, this really shouldn't be, right? Because we risk the chance that there's a track with one we can't remove? If this statement is true, can you adjust your PR to explain that this is blocked by #5229?

Good point. I'll update.

@ryuukumar ryuukumar mentioned this pull request Jul 21, 2020
Closed
56 tasks
@PhysSong PhysSong mentioned this pull request Jan 31, 2022
Merged
@PhysSong
Copy link
Member

Resolved conflicts while working on #5229.

@Rossmaxx
Copy link
Contributor

@PhysSong I merged #5229, Are we clear to merge this too and get done with global automation?

@PhysSong
Copy link
Member

@PhysSong I merged #5229, Are we clear to merge this too and get done with global automation?

I think this PR is no longer blocked, but we might not be able to say done because step 4 (removing the global automation functionality from core) is not done.

@messmerd messmerd mentioned this pull request Feb 22, 2025
Open
4 tasks
@tresf tresf added this to the 1.3 milestone Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@Veratil @LmmsBot @tresf @PhysSong @Rossmaxx