Skip to content

Set minimum deployment target for macOS builds #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

messmerd
Copy link
Member

@messmerd messmerd commented Jul 11, 2025

Our macOS builds do not set a minimum deployment target, which (I believe) makes XCode/AppleClang default to the same version as the host. So on Nightly, this would mean the minimum macOS version is 13 (Ventura) on x86_64 and 14 (Sonoma) on arm64. This places an unnecessary restriction on users, which is a problem.

So I've lowered the minimum deployment target to the lowest values it will allow:
10.13 (High Sierra) for x86_64, and 11.0 (Big Sur) for arm64

NOTE: I added the minimum deployment target to the ccache key. I'm not really sure if this is necessary. If not, I can remove it.

10.13 (High Sierra) for x86_64, and 11.0 (Big Sur) for arm64
@Mr-Emoticon63
Copy link

Mr-Emoticon63 commented Jul 12, 2025

OH MY GOD THANK YOU SO MUCH YOU ARE AMAZING also can you explain how you did this I really want to know :)

Edit: Just checked the nightly and it still says that it requires MacOS 13.7 for whatever reason.

@messmerd
Copy link
Member Author

@Mr-Emoticon63 Thanks! I just had to set a compiler option to allow support for older macOS versions.

This isn't in nightly yet (since this PR hasn't been merged), but you can try it out here: https://lmms.io/download/pull-request/8004

If you do try it out, please let me if it worked for you. I don't have a Mac so I can't test it myself.

@Mr-Emoticon63
Copy link

it’s not loading for whatever reason.

@Mr-Emoticon63
Copy link

it just says “504 Gateway Time-out”

@Mr-Emoticon63
Copy link

uh oh none of the lmms website is loading 🥲

@AW1534
Copy link
Member

AW1534 commented Jul 13, 2025

uh oh none of the lmms website is loading 🥲

The website is down currently, but the latest build in this PR (as of when this comment is uploaded) can be grabbed from here: https://github.com/LMMS/lmms/actions/runs/16230943390#artifacts

@Mr-Emoticon63
Copy link

yeah it worked. Now we just wait for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants