PianoRoll: fix getKey and remove dead code #8008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allejok96
changed the title
allejok96
changed the title
JohannesLorenz
approved these changes
Jul 16, 2025
| @@ -343,6 +342,9 @@ protected slots: | |||
| int noteEditRight() const; | |||
| int noteEditLeft() const; | |||
|
|
|||
| int getKey(const int y) const; | |||
There was a problem hiding this comment.
You can use const in the definition. However, in the declaration, it does not make sense, and thus often causes compiler warnings (having const only in the definition does not cause them).
| return key_num; | ||
| // If y == keyAreaBottom() the cursor is on the first pixel BELOW the editor | ||
| // and thus its distanceFromBottom should be -1. We calculate the distance from | ||
| // ABSOLUTE bottom before dividing, because integer division with negative numbers |
There was a problem hiding this comment.
because integer division with negative numbers causes rounding issues
What does this mean? Can you explain, maybe with a simple example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getKey()is off by 2 pixelsyCoordOfKey()which is the reverse ofgetKey()