-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add simple versioned autosave. #8084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Each autosave now adds a patterned file based on the time, to have a version history of sorts. I wager that people who have autosaves turned on will not be affected by too many files.
48327b3 to
3d3ce31
Compare
I think there are users that have autosave turned on, but do not really care for the entire history of the project each time it is saved and would only want the latest version. |
maybe there could be an option to choose between the entire history of the project to just the latest save. Maybe like the past 3 saves could be kept. The user would be able to choose, however. |
Main: Add m_modifiedautosave flag to reduce autosave spam for previous versioned/timestamped autosave commit. Side: Remove weird Song *song thingy with the intended code.
|
I'll see if I can understand the option stuff and GUI, and will add a checkbox next to enabling autosaves next. |
i mean like a slider that goes between keeping only the latest save and keeping all saves. |
|
Having a full version history would be very helpful (and eventually obsolete the "Save as new version" action), so I'm very much on board with this. So my most conservative estimate on my machine is that, if all project files were that big, the size of all version history snaphots would be around 60MB per project after 10h of work at one autosave every minute. Not too much overall, but significant enough that a cleanup function would make sense. I see an issue with the idea of making this a GUI slider that the user can modify at any time though: Let's say you already have a project with a version history of 100 files, then you change that GUI slider from "keep all files" to "keep the last 3 versions" and then you open the project with that full history. What happens on the next timer-triggered autosave? Does the version history get wiped out? |
-Add a toggle for versioned autosaves, checkbox in Performance->Autosave section. -Make the timestamping easier to read. -Make timestamp not use miliseconds. (Overkill.) -Formatting fixes.
9e4ac26 to
247308a
Compare
-Autosave toggle now behaves as expected on pressing the reset button. -Autosave toggle is now hidden when autosave is disabled. -Remove empty line.
Each autosave now adds a patterned file based on the time, to have a version history of sorts.
I wager that people who have autosaves turned on will not be affected by too many files.