Fix MixerChannel effect chain initialization with null parent #8095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MixerChannel constructor was initializing m_fxChain with nullptr instead of the proper parent model. This caused mixer channels to appear in the UI but not function properly - they wouldn't process or output audio. The effect chain needs a valid parent to be properly connected to the model hierarchy for signal/slot connections and proper functionality. Fixes the bug where certain mixer channels appear but don't output anything.
Member
|
Is there a way to reproduce the issue and test this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MixerChannel constructor was initializing m_fxChain with nullptr instead of the proper parent model. This caused mixer channels to appear in the UI but not function properly - they wouldn't process or output audio.
The effect chain needs a valid parent to be properly connected to the model hierarchy for signal/slot connections and proper functionality.
Fixes the bug where certain mixer channels appear but don't output anything.