Improve setModified behaviour and journal checkpoints #8115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setModified behaviour is currently inconsistent.
Tempo, Global Transpose, and Global Volume for example get added to the journal, but do not call setModified.
Muting, Unmuting and Soloing tracks set neither, but are saved in the song, so they should set both.
The first commit moved the setModified check to the journal.
On project load with instrument plugins, several blank? journal entries are created, that to my knowledge don't do anything.
The second commit removed AutomatableModel.cpp line 307: addJournalCheckPoint();
This fixes the blank? journal entries on load.
I am currently checking if there are any unintended changes.
So far, I have noticed none.
This draft will get updated as I work through this.