Add creatorplatform to determine where a project originated for future use.#8116
Add creatorplatform to determine where a project originated for future use.#8116rubiefawn merged 10 commits intoLMMS:masterfrom
Conversation
|
No requests for a namechange have been made. |
|
I would personally prefer more information for diagnostic purposes, so I don't see why we wouldn't want to use |
|
Because of hopefully platform generic code. I am not opposed to add a second identifier however. |
This reverts commit 31f5d6e.
rubiefawn
left a comment
There was a problem hiding this comment.
LGTM, just make sure to update any lines you modify so that they conform to our coding conventions.
|
Tested, can confirm my save file now begins with: <lmms-project version="31" type="song" creatorplatform="linux" creator="LMMS" creatorversion="1.3.0-alpha.1.908+b69f5a8" creatorplatformtype="cachyos"> |
Co-authored-by: Fawn <rubiefawn@gmail.com>
Co-authored-by: Fawn <rubiefawn@gmail.com>
As mentioned in #8103 (comment) , a platform identifier should be added.
KernelType delivers the most agnostic platform info from native Qt, as ProductType would return "Fedora", "OpenSUSE", etc..
If we want to decollate the rest (Android vs. Desktop Linux = "linux", iOS vs. Mac OS X = "darwin"), we'd have to write our own implementation.