Skip to content

Add creatorplatform to determine where a project originated for future use.#8116

Merged
rubiefawn merged 10 commits intoLMMS:masterfrom
Jan125:creatorplatform
Dec 2, 2025
Merged

Add creatorplatform to determine where a project originated for future use.#8116
rubiefawn merged 10 commits intoLMMS:masterfrom
Jan125:creatorplatform

Conversation

@Jan125
Copy link
Contributor

@Jan125 Jan125 commented Nov 2, 2025

As mentioned in #8103 (comment) , a platform identifier should be added.

KernelType delivers the most agnostic platform info from native Qt, as ProductType would return "Fedora", "OpenSUSE", etc..
If we want to decollate the rest (Android vs. Desktop Linux = "linux", iOS vs. Mac OS X = "darwin"), we'd have to write our own implementation.

@Jan125
Copy link
Contributor Author

Jan125 commented Nov 15, 2025

No requests for a namechange have been made.

@Jan125 Jan125 marked this pull request as ready for review November 15, 2025 13:11
@rdrpenguin04
Copy link
Contributor

I would personally prefer more information for diagnostic purposes, so I don't see why we wouldn't want to use ProductType. That's just my opinion though; is there a specific reason you wanted to go with the more generic names?

@Jan125
Copy link
Contributor Author

Jan125 commented Nov 16, 2025

Because of hopefully platform generic code.
If a project needs to be checked if it came from a linux build, it should be a unified name for that platform, for code to properly handle it. (We're not building for Fedora or Ubuntu etc. specifically anyway.)

I am not opposed to add a second identifier however.

@Jan125 Jan125 marked this pull request as draft November 16, 2025 07:39
@Jan125 Jan125 marked this pull request as ready for review November 16, 2025 07:45
Copy link
Contributor

@rubiefawn rubiefawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure to update any lines you modify so that they conform to our coding conventions.

@rubiefawn
Copy link
Contributor

Tested, can confirm my save file now begins with:

<lmms-project version="31" type="song" creatorplatform="linux" creator="LMMS" creatorversion="1.3.0-alpha.1.908+b69f5a8" creatorplatformtype="cachyos">

Jan125 and others added 2 commits December 2, 2025 18:05
Co-authored-by: Fawn <rubiefawn@gmail.com>
Co-authored-by: Fawn <rubiefawn@gmail.com>
@rubiefawn rubiefawn merged commit 58a4a8a into LMMS:master Dec 2, 2025
11 checks passed
@Jan125 Jan125 deleted the creatorplatform branch December 23, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants