Add quality of life features. Duplication (ctrl-d), zooming with ctrl - and ctrl =, vertical flipping of notes in piano roll. #8143
Conversation
…s. Ctrl + and ctrl - will zoom in and out in the piano and automation editor
| } | ||
| break; | ||
|
|
||
| case Qt::Key_Equal: |
There was a problem hiding this comment.
Why not do these as a QAction too?
There was a problem hiding this comment.
We can do that, this just seemed like a more straight forward approach.
There was a problem hiding this comment.
Use QKeySequence::ZoomIn and ZoomOut. That solves the issue with different keyboard layouts and platforms. For example, on my keyboard 0=} is the same key, and ?+\ is another key
|
#7873 may be related, at least for the note duplication shortcut. I am curious, reading the code, it appears that I am also interested what the use-cases are for vertically flipping a selection of notes. Given how scales are usually not evenly spaced, flipping a set of notes would easily create some off-scale notes. Actually, maybe that would be kind of cool sometimes. The key bind zooming sounds cool for keyboard users. I think we have something similar with a mouse shortcut, but having a purely keyboard one is probably a good idea too. |
|
some thoughts:
|
Great ideas. |
Yes, duplicate notes does act like shift dragging. |
Ctrl+0 and alt+0 are already used for setting quantization and note durations, maybe this can be revised later
|
Flipping a melody vertically turns major into minor and vice versa, it's pretty cool that it even works |
|
I'd almost want to request horizontal flipping; I find myself doing that fairly often |
|
Shift+R 
|
| const NoteVector selectedNotes = getSelectedNotes(); | ||
| const auto& notes = selectedNotes.empty() ? m_midiClip->notes() : selectedNotes; | ||
|
|
||
| m_midiClip->flipNotes(notes); |
There was a problem hiding this comment.
I understand that having Clip::flipNotes is neat, but I don't like that you can pass notes from any clip to it (yeah reverseNotes does it too). I'd rather see that the selection happens inside Clip::flipNotes. It's not a deal breaker though... I need a second opinion on this...
| m_midiClip->flipNotes(notes); | ||
|
|
||
| update(); | ||
| getGUI()->songEditor()->update(); |
There was a problem hiding this comment.
Are these update calls needed? Try without. At least the first one should not be needed since the editor connects to Clip::dataChanged
| int min = notes.at(0)->key(); | ||
| int max = notes.at(0)->key(); | ||
|
|
||
| for (auto note : notes) | ||
| { | ||
| int key = note->key(); | ||
| if (key > max) { max = key; } | ||
| if (key < min) { min = key; } | ||
| } | ||
|
|
||
| int sum = min + max; |
There was a problem hiding this comment.
| int min = notes.at(0)->key(); | |
| int max = notes.at(0)->key(); | |
| for (auto note : notes) | |
| { | |
| int key = note->key(); | |
| if (key > max) { max = key; } | |
| if (key < min) { min = key; } | |
| } | |
| int sum = min + max; | |
| auto bounds = boundsForNotes(notes) | |
| int sum = bounds->lowest + bounds->highest; |
| } | ||
| } | ||
|
|
||
| void PianoRoll::duplicateNotes() |
There was a problem hiding this comment.
Like regulus said, there's no need for duplicate since #7873 does that better
#7941 (just nagging people) |
5 participants
Note duplication
duplication.mp4
Note flipping
flipping.mp4
Key bind zooming
zooming.mp4