Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commitment and API changes for v0.11 #147

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Commitment and API changes for v0.11 #147

merged 6 commits into from
Oct 30, 2023

Conversation

dr-orlovsky
Copy link
Member

Since we break consensus anyway in v0.11 I made these changes that were impossible before. They aim to standardize merklization better.

@dr-orlovsky dr-orlovsky added *security* Issues affecting safety/security (include undefined behaviours) *consensus* Issues affecting distributed concensus refactoring Refactoring of the existing code labels Oct 29, 2023
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Files Coverage Δ
commit_verify/src/mpc/atoms.rs 41.0% <100.0%> (+4.1%) ⬆️
commit_verify/src/mpc/block.rs 81.4% <100.0%> (ø)
commit_verify/src/convolve.rs 80.0% <66.7%> (-3.3%) ⬇️
src/api.rs 72.5% <50.0%> (ø)
single_use_seals/src/lib.rs 0.0% <0.0%> (ø)
commit_verify/src/merkle.rs 81.7% <50.0%> (-3.7%) ⬇️

📢 Thoughts on this report? Let us know!.

zoedberg
zoedberg approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dr-orlovsky dr-orlovsky merged commit 672e628 into master Oct 30, 2023
22 of 23 checks passed
@Gigi3d
Copy link

Gigi3d commented Nov 1, 2023

LFG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoedberg zoedberg zoedberg approved these changes

@nicbus nicbus Awaiting requested review from nicbus

Assignees
No one assigned
Labels
*consensus* Issues affecting distributed concensus refactoring Refactoring of the existing code *security* Issues affecting safety/security (include undefined behaviours)
Projects
Releases & roadmap
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dr-orlovsky @Gigi3d @zoedberg