Conversation
d4500a2 to
ca516b7
Compare
|
I'm trying to understand the changes, so first of all sorry if what I'm saying is irrelevant/off the mark. Wouldn't it be better to systematically transform a spill (idea stolen from Cyril). Basically, eta-expanding and then "limiting the scope" of the spill unification variable. This way we would keep spills inside partial applications possible (which is a nice feature in my opinion) and doing things like this would work, as one might intuitively expect: where prior to this PR crashed with the "Unification problem outside the pattern fragment." error and with this PR unification fails. |
8929bea to
052c71d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new algorithm:
once finished