Update symbols and index when extending with a signature#372
Merged
gares merged 6 commits intoLPCIC:masterfrom Sep 24, 2025
Merged
Update symbols and index when extending with a signature#372gares merged 6 commits intoLPCIC:masterfrom
gares merged 6 commits intoLPCIC:masterfrom
Conversation
1 task
Contributor
|
did the cleanup. I'll think about the whole thing once more and then merge |
gares
force-pushed
the
janno/fix-extend-signature
branch
from
558c96c to
b16e1e5
Compare
gares
approved these changes
Sep 24, 2025
gmalecha
reviewed
Sep 24, 2025
| symbs |> List.filter_map (fun (symb, { TypingEnv.indexing } ) -> match indexing with Index m -> Some (symb, m) | _ -> None) | ||
|
|
||
| let allocate_new_symbols state ~symbols ~new_defined_symbols = | ||
| (* THE MISTERY: allocating symbols following their declaration order makes the grundlagen job 30% faster (600M less memory): |
Contributor
There was a problem hiding this comment.
There is a lot of mist around this mystery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.