Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor defaults and cli #35

Merged
merged 28 commits into from
Nov 4, 2024
Merged

refactor defaults and cli #35

merged 28 commits into from
Nov 4, 2024

Commits on Nov 4, 2024

  1. avoid repeated nuts code throughout codebase

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    92b576a View commit details
    Browse the repository at this point in the history

  2. refactor and use new function

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    55e1a0a View commit details
    Browse the repository at this point in the history

  3. sigma seems off by sqrt(2)

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    caeefeb View commit details
    Browse the repository at this point in the history

  4. rename

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4656c43 View commit details
    Browse the repository at this point in the history

  5. being careful with defaults

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1ab0594 View commit details
    Browse the repository at this point in the history

  6. being careful with defaults and renaming

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    29abcda View commit details
    Browse the repository at this point in the history

  7. renaming

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    194432e View commit details
    Browse the repository at this point in the history

  8. reorder

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5d2a8f1 View commit details
    Browse the repository at this point in the history

  9. avoid certain defaults for now

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    be03c71 View commit details
    Browse the repository at this point in the history

  10. we dont need these ones anymore

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4475bec View commit details
    Browse the repository at this point in the history

  11. need to remove prior and move to target

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1db59ba View commit details
    Browse the repository at this point in the history

  12. fix test after refactoring

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    534117e View commit details
    Browse the repository at this point in the history

  13. use typer

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e0803fa View commit details
    Browse the repository at this point in the history

  14. typo

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d9dcba6 View commit details
    Browse the repository at this point in the history

  15. typo

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    50016fd View commit details
    Browse the repository at this point in the history

  16. fix tests

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a47cae3 View commit details
    Browse the repository at this point in the history

  17. rename and use typer

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    12eb215 View commit details
    Browse the repository at this point in the history

  18. rename

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5890174 View commit details
    Browse the repository at this point in the history

  19. more judicious

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1ddfe9d View commit details
    Browse the repository at this point in the history

  20. step size, no default

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0f62810 View commit details
    Browse the repository at this point in the history

  21. need more arguments now

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8886023 View commit details
    Browse the repository at this point in the history

  22. rtol change to be appropriate int est

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1c10d0c View commit details
    Browse the repository at this point in the history

  23. fix

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4cb3d75 View commit details
    Browse the repository at this point in the history

  24. high snr is the default

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d27a729 View commit details
    Browse the repository at this point in the history

  25. add typer, but finish in next PR

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9bdac2f View commit details
    Browse the repository at this point in the history

  26. rename

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    68965df View commit details
    Browse the repository at this point in the history

  27. rename

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    87da98e View commit details
    Browse the repository at this point in the history

  28. fix corersponding slurm script

    @ismael-mendoza
    ismael-mendoza committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    da62ed4 View commit details
    Browse the repository at this point in the history