Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of kwargs vs self.kwargs and load_classifier #68

Closed
drewoldag opened this issue Oct 31, 2024 · 0 comments · Fixed by #69
Closed

Incorrect use of kwargs vs self.kwargs and load_classifier #68

drewoldag opened this issue Oct 31, 2024 · 0 comments · Fixed by #69
Assignees
Labels
bug Something isn't working

Comments

@drewoldag
Copy link
Collaborator

In some ResspectClassifier subclasses, we expect there to be specific kwargs provided. We use get to pull the expected keys from the kwarg dict, but then pass the **kwarg to the classifier definition as well.

This results in parameters being passed twice.

Additionally, the method to load a pretrained classifier is called load_classifier, but in database.py it is referred to as load. So we need to update the name there.

@drewoldag drewoldag added the bug Something isn't working label Oct 31, 2024
@drewoldag drewoldag self-assigned this Oct 31, 2024
@drewoldag drewoldag linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant