Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing classifier-related bugs #69

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

drewoldag
Copy link
Collaborator

Need to use self.kwargs.pop(foo, bar) in the classifier subclasses so that the key/values are removed from the kwargs dict, and not passed to the classifier instance twice.

Also need to use the correct method name, load_classifier instead of load when using a ResspectClassifier subclass in database.py.

@drewoldag drewoldag self-assigned this Oct 31, 2024
@drewoldag drewoldag linked an issue Oct 31, 2024 that may be closed by this pull request
Copy link

Before [56fad73] After [d5da3ad] Ratio Benchmark (Parameter)
155±2ms 159±3ms 1.03 benchmarks.time_learn_loop('KNN', 'UncSampling')
195M 197M 1.01 benchmarks.peakmem_learn_loop('KNN')
186M 188M 1.01 benchmarks.peakmem_learn_loop('RandomForest')
151±0.8ms 153±2ms 1.01 benchmarks.time_learn_loop('KNN', 'RandomSampling')
2.59±0.01s 2.62±0.01s 1.01 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
135±2ms 135±1ms 1 benchmarks.time_feature_creation
2.59±0s 2.56±0.01s 0.99 benchmarks.time_learn_loop('RandomForest', 'UncSampling')

Click here to view all benchmarks.

@drewoldag drewoldag merged commit 305d6ec into main Nov 1, 2024
7 checks passed
@drewoldag drewoldag deleted the issue/68/fix-classifier-bugs branch November 1, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect use of kwargs vs self.kwargs and load_classifier
2 participants