generalize fit() for non Ia applications #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click here to view all benchmarks. |
drewoldag
approved these changes
Oct 21, 2024
| additional_info: list = []): | ||
| """ | ||
| Perform fit to all objects from a generalized dataset. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| data_dic: str | ||
| Dictionary containing the photometry for all light curves. | ||
| data_dic: list |
There was a problem hiding this comment.
Suggested change
| data_dic: list | |
| data_dic: list[dict] |
Minor point - doesn't need to be fixed in this PR - but since data_dic is now expected to be a list, it might make sense to simply call it data.
Co-authored-by: Drew Oldag <[email protected]>
drewoldag
added a commit
that referenced
this pull request
Oct 30, 2024
* generalize fit() for non Ia applications * Update src/resspect/fit_lightcurves.py Co-authored-by: Drew Oldag <[email protected]> --------- Co-authored-by: Drew Oldag <[email protected]>
drewoldag
added a commit
that referenced
this pull request
Oct 31, 2024
* WIP - Initial work to implement pluggable feature extractors - Unit tests are not passing, need to make a thorough scan of the code for lowercase references to feature extractors. i.e. "bazin" vs. "Bazin". * Initial commit for pluggable query_strategies. (#59) * generalize fit() for non Ia applications (#56) * generalize fit() for non Ia applications * Update src/resspect/fit_lightcurves.py Co-authored-by: Drew Oldag <[email protected]> --------- Co-authored-by: Drew Oldag <[email protected]> * Attempted to clean up references to default values of `bazin` and replaced with `Bazin`. * Introduce logic to ease the transition from lower case to upper case feature extractor names. Adding tests. --------- Co-authored-by: AmandaWasserman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize so that fit() can be used for other instances than Ia/non Ia.
Still need to work on ideas for a multi-class abilitiy.