Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing erronious GNU GPL notifications from the source tree. #65

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mtauraso
Copy link
Collaborator

@mtauraso mtauraso commented Oct 31, 2024

  • This was missed when the LICENSE file was changed to MIT
  • Collecting information from Amanda, Emille, Rob, and Alex I believe the notices to be in error, and the entirety of this repository is MIT licensed from LSSTDESC at this time.

No more source code matches for GNU or GPL on this branch:

mtauraso@Michaels-MacBook-Pro RESSPECT % grep -rni gpl ./*
Binary file ./data/tests/RESSPECT_PHOTO.csv.gz matches
Binary file ./docs/images/active_learning_loop.png matches
mtauraso@Michaels-MacBook-Pro RESSPECT % grep -rni gnu ./*

- This was missed when the LICENCE file was changed to MIT
- Collecting information from Amanda, Emille, Rob, and Alex I believe
  the notices to be in error, and the actual status of the codebase at
  time of writing is that the entirety of it is MIT licensed.
Copy link

Before [c683c9b] After [2849edd] Ratio Benchmark (Parameter)
149±1ms 151±2ms 1.01 benchmarks.time_learn_loop('KNN', 'RandomSampling')
151±2ms 152±2ms 1.01 benchmarks.time_learn_loop('KNN', 'UncSampling')
197M 196M 1 benchmarks.peakmem_learn_loop('KNN')
188M 188M 1 benchmarks.peakmem_learn_loop('RandomForest')
131±3ms 131±1ms 1 benchmarks.time_feature_creation
2.55±0.02s 2.53±0s 0.99 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
2.58±0.03s 2.56±0.01s 0.99 benchmarks.time_learn_loop('RandomForest', 'UncSampling')

Click here to view all benchmarks.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@mtauraso mtauraso merged commit 444e421 into main Nov 1, 2024
7 checks passed
@mtauraso mtauraso deleted the remove-gpl branch November 1, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants