Refactoring in support of externally defined feature extractor libraries - i.e. LAISS #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghtcurve_utils`. Dynamically generate the column names as needed using methods defined in the `LightCurve` feature extractor subclasses.
Click here to view all benchmarks. |
drewoldag
commented
Nov 1, 2024
maxwest-uw
approved these changes
Nov 5, 2024
… and self.metadata_names.
drewoldag
commented
Nov 7, 2024
| @@ -234,6 +239,10 @@ def load_features_from_file(self, path_to_features_file: str, screen=False, | |||
| "Bump", or "Malanchev". Default is "Bazin". | |||
| """ | |||
|
|
|||
| if survey not in ['DES', 'LSST']: | |||
There was a problem hiding this comment.
@AmandaWasserman Is this logic correct, or should we support any survey that we find in the FILTER_SETS dictionary? i.e. DES, LSST, and SNPCC
- Image installs resspect from source - Image builds on latest ubuntu avoiding conflicts with ubuntu's version of pip - Image sets up a data directory and a venv for resspect - Image does not yet work with the docker-compose file or the TOM docker-compose ecosystem.
And document how to connect to tom docker-compose ecosystem
|
Everything looks good doing a PR and run through of our typical operations for feature extraction, learn loop, and plotting |
drewoldag
deleted the
issue/72/refactor-feature-extractor-column-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fairly substantial refactor removes hardcoded column names from
lightcurve_utilsand shifts the work over to the subclasses ofLightCurve. The built in feature extractors (FEs) all use the same patterns, so we were able to keep the logic in the parent class.This reduces the code in RESSPECT, and leaves the door open for external libraries that bring in a FE to implement their own method of providing feature column names.