Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing vestigial container #75

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Removing vestigial container #75

merged 1 commit into from
Nov 19, 2024

Conversation

mtauraso
Copy link
Collaborator

@mtauraso mtauraso commented Nov 7, 2024

Per slack conversation this is dead code.

@mtauraso mtauraso self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Before [7c56dc6] After [56516b6] Ratio Benchmark (Parameter)
131±0.8ms 133±2ms 1.01 benchmarks.time_feature_creation
188M 188M 1 benchmarks.peakmem_learn_loop('RandomForest')
148±2ms 148±1ms 1 benchmarks.time_learn_loop('KNN', 'RandomSampling')
152±2ms 152±0.9ms 1 benchmarks.time_learn_loop('KNN', 'UncSampling')
199M 197M 0.99 benchmarks.peakmem_learn_loop('KNN')
2.60±0.01s 2.55±0.01s 0.98 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
2.61±0.01s 2.55±0.01s 0.98 benchmarks.time_learn_loop('RandomForest', 'UncSampling')

Click here to view all benchmarks.

@mtauraso mtauraso merged commit e42321b into main Nov 19, 2024
8 checks passed
@mtauraso mtauraso deleted the remove-extra-container branch November 19, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants