-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The current view only displays one item per line, which becomes a problem when loot tables are large. As loot tables are mainly about what items are in them, this PR simplifies the view to just show an inline list of slots, just like LU's inventory does. As for the other columns, `id` never seems to be used in the game and is probably an auto-added primary key. `missionDrop` is indicated by highlighting the slot. `sortPriority` is not displayed directly, but is used to order the items. Sorting is also moved from JS to CSS, as it is only used in presentation. As `sortPriority` is also only used by LU to order items, without the precise value being of much importance, not displaying it directly seems like an acceptable tradeoff for a much more compact representation of loot tables.
- Loading branch information
Showing
4 changed files
with
13 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
ul { | ||
display: flex; | ||
flex-wrap: wrap; | ||
} | ||
|
||
li { | ||
display: block; | ||
} |
7 changes: 2 additions & 5 deletions
7
src/app/objects/loot/loot-table-index/loot-table-index.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
<ul *ngIf="loot_table"> | ||
<li *ngFor="let entry of loot_table"> | ||
<lux-slot [luxFetchItem]="entry.itemid"></lux-slot> | ||
<span *ngIf="entry.MissionDrop"> [MissionDrop]</span> | ||
(sortPriority: {{entry.sortPriority}}; | ||
id: {{entry.id}}) | ||
<li *ngFor="let entry of loot_table" [style.order]="entry.sortPriority"> | ||
<lux-slot [luxFetchItem]="entry.itemid" [equipped]="entry.MissionDrop"></lux-slot> | ||
</li> | ||
</ul> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
<h2>Loot Table ({{id}})</h2> | ||
<h2>Loot Table #{{id}}</h2> | ||
<p>Highlighted items are mission drops.</p> | ||
<app-loot-table-index [id]="id"></app-loot-table-index> |