LibWasm: Ensure correct section ordering when parsing binary modules #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are (currently) no spec-tests ensuring that section ordering is enforced, but it _is_ a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775.
|
Nice, thanks for the spec tests as well! |
alimpfard
approved these changes
Aug 10, 2024
|
@alimpfard I just realized that this PR might have a bug. Is ordering automatically derived in an |
|
I've tested manually that this PR works on my machine, but I'm not sure if it the automatic derivation is standardized across GNU and clang. |
Yes, values are automatically assigned starting from zero. |
|
Ok, thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are (currently) no spec-tests ensuring that section ordering is enforced, but it is a part of the spec. A pull request to add this to the specification testsuite has been opened at WebAssembly/spec#1775.