Mask image scroll offset #4312
Closed
Mask image scroll offset #4312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes icon SVGs not disappear when scrolling on https://www.fangamer.com/. Icons on this site are boxes with background colours, with the SVG of the icon masking it with mask-image.
Collaborator
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
pixelspark
force-pushed
the
mask-image-scroll-offset
branch
from
6d106c2 to
c16dd5c
Compare
pixelspark
force-pushed
the
mask-image-scroll-offset
branch
from
c16dd5c to
7252b7e
Compare
pixelspark
force-pushed
the
mask-image-scroll-offset
branch
from
7252b7e to
1056c17
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR by @Lubrsi was automatically closed, but it fixes an issue that affects my personal website so I thought let's fix it :-)
My PR adds the requested 'test flakiness' fix (it uses an external SVG file instead of a data URI and has an img tag to load the image) to the previous work done in #3646.
Note that (at least on my mac) there seems to be an issue updating the mask position now (it only does so after hovering over one of the masked items. On my website this triggers a change in CSS transform). Any pointers on how to fix this would be appreciated!