Skip to content

LibWeb/IDB: Implement enough to add entries to an ObjectStore #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 23, 2025
Merged

LibWeb/IDB: Implement enough to add entries to an ObjectStore #4317

merged 19 commits into from
Apr 23, 2025

Conversation

stelar7
Copy link
Contributor

@stelar7 stelar7 commented Apr 11, 2025

No description provided.

kennethmyhra
kennethmyhra reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@kennethmyhra kennethmyhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice! I've added a few comments

@stelar7 stelar7 force-pushed the idb-the-first-add branch from 1b08396 to bd53884 Compare April 16, 2025 20:12
@kennethmyhra
Copy link
Contributor

I noticed we are passing a few more WPT tests after this so probably worth pulling those in

We pass all tests on IndexedDB/key_invalid.any.html

And we are passing 6 of 16 on each of these: IndexedDB/idbobjectstore_add.any.html, IndexedDB/idbobjectstore_put.any.html

@stelar7
Copy link
Contributor Author

stelar7 commented Apr 18, 2025

Most of the tests rely on functionality thats still missing, so i didnt see any point of adding those before that 😅

kennethmyhra
kennethmyhra approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@kennethmyhra kennethmyhra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ADKaster
ADKaster reviewed Apr 19, 2025
View reviewed changes
@stelar7 stelar7 force-pushed the idb-the-first-add branch 3 times, most recently from 49b7ca2 to 133e0e0 Compare April 19, 2025 17:01
@stelar7 stelar7 force-pushed the idb-the-first-add branch from 133e0e0 to 67c20bc Compare April 23, 2025 08:00
stelar7 added 19 commits April 23, 2025 10:21
@stelar7
LibWeb/IDB: Implement clone_in_realm
79abae8
@stelar7
LibWeb/IDB: Adjust return type of convert_a_value_to_a_key
1c0158a
@stelar7
LibWeb/IDB: Implement convert_a_value_to_a_multi_entry_key
7178592
@stelar7
LibWeb/IDB: Implement evaluate_key_path_on_a_value
e8d322e
@stelar7
LibWeb/IDB: Implement extract_a_key_from_a_value_using_a_key_path
345915e
@stelar7
LibWeb/IDB: Implement check_that_a_key_could_be_injected_into_a_value
d9a0f1b
@stelar7
LibWeb/IDB: Change return type of IDBRequest::error()
dae0d3f
@stelar7
LibWeb/IDB: Implement fire_an_error_event
ab4ccb7
@stelar7
LibWeb/IDB: Implement fire_a_success_event
0c13b93
@stelar7
LibWeb/IDB: Implement more of IDBCursor
6f06b84
@stelar7
LibWeb/IDB: Implement asynchronously_execute_a_request
f53ac55
@stelar7
LibWeb/IDB: Implement generate_a_key
d737f24
@stelar7
LibWeb/IDB: Implement possibly_update_the_key_generator
366e5f4
@stelar7
LibWeb/IDB: Implement inject_a_key_into_a_value_using_a_key_path
f5507f0
@stelar7
LibWeb/IDB: Implement delete_records_from_an_object_store
5e06678
@stelar7
LibWeb/IDB: Implement store_a_record_into_an_object_store
fe67054
@stelar7
LibWeb/IDB: Implement IDBObjectStore::add_or_put
f902942
@stelar7
LibWeb/IDB: Implement IDBObjectStore::add
c175e26
@stelar7
LibWeb/IDB: Implement IDBObjectStore::put
7e990df
@stelar7 stelar7 force-pushed the idb-the-first-add branch from 67c20bc to 7e990df Compare April 23, 2025 08:21
@ADKaster ADKaster enabled auto-merge (rebase) April 23, 2025 08:28
@stelar7
Copy link
Contributor Author

stelar7 commented Apr 23, 2025

CI unrelated

@ADKaster
Copy link
Member

the new flake Fail: Layout/input/table/propagate-style-update-to-wrapper.html seems particularly ... not flaky.

@ADKaster ADKaster disabled auto-merge April 23, 2025 18:31
@ADKaster ADKaster merged commit 5d48652 into LadybirdBrowser:master Apr 23, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethmyhra kennethmyhra kennethmyhra approved these changes

@ADKaster ADKaster ADKaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stelar7 @kennethmyhra @ADKaster