-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Trusted types Continuation #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tete17
wants to merge
13
commits into
LadybirdBrowser:master
Choose a base branch
from
tete17:Trusted-Types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,518
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
requested changes
Jul 31, 2025
Lubrsi
requested changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thanks for importing tests showing that this works. This addresses several code smells to bring the implementation more in line with our code style and some issues I noticed.
This allows authors to check if a Trusted Type is required for the given Elements property. This adds 28 more passing WPT tests :)
The TrustedHTML interface represents a string that a developer can confidently insert into an injection sink that will render it as HTML. These objects are immutable wrappers around a string, constructed via a TrustedTypePolicy’s createHTML method.
This is used to check the legitimacy of a TrustedHTML object.
It is mostly a skeleton with no actual implementation.
It simply consists of a wrapper around the main algorithm
This is the mechanism that should pages to determine what kind of policies can be created on their domains mostly based around the HTTP headers the server responds with.
This is the main mechanism by which users of the api can create safe object with a callback for any needed sanitation of the values.
This turns out to be very similar to TrustedHTML.
This changes should allow us to now call createScript as well.
This completes the 3 main TrustedType classes.
This gives us at least 72 new tests :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work started in #5430
This time the focus is on being able to create policies via
TrustedTypePolicyFactory::create_policy
& being able to created TrustedTypes withTrustedTypePolicy::create_(html|script|script_url)
This unluck a good set of wpt tests in the trusted-types section.
My plan is to focus next on integrating this with the injection sinks api.