[testing] feat: integrate mp2 batch queries feature #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
force-pushed
the
batch-queries-integration
branch
5 times, most recently
from
deb12f2 to
0d1dac6
Compare
silathdiir
force-pushed
the
batch-queries-integration
branch
from
0d1dac6 to
1e56b5e
Compare
silathdiir
changed the title
silathdiir
requested review from
delehef,
hackaugusto,
nikkolasg and
nicholas-mainardi
delehef
reviewed
Dec 13, 2024
delehef
approved these changes
Dec 13, 2024
nikkolasg
reviewed
Dec 16, 2024
lgn-provers/Cargo.toml
Outdated
Comment on lines
23
to
36
| "contract", | ||
| "node-bindings", | ||
| "providers", | ||
| "network", | ||
| "signer-local", | ||
| "sol-types", | ||
| "rpc", | ||
| "rpc-types", | ||
| "consensus", | ||
| "rlp", | ||
| "transports", | ||
| "transport-http", | ||
| "reqwest", | ||
| ] } |
There was a problem hiding this comment.
Do we really need all these features ?
There was a problem hiding this comment.
No, I fix to delete the useless alloy features in commit 0e7109b.
| ) -> anyhow::Result<Vec<u8>> | ||
| { | ||
| Ok(dummy_proof(PROOF_SIZE)) | ||
| } | ||
|
|
||
| fn prove_single_path_branch( | ||
| fn prove_non_existence( |
There was a problem hiding this comment.
I dont think this one needs to exists anymore ? Non existence is just providing one input like any other no ? @nicholas-mainardi
There was a problem hiding this comment.
For rows tree with no matching rows yes, but we still have a circuit to prove non existence of nodes in the index tree. I suppose that this variant refers to this circuit?
There was a problem hiding this comment.
This corresponds to the non-existence proving logic in the batching queries integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRY-15
Related distributed-query PR #973
TODO
colberg.dev1.