Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce the state verification error #34

Open
wants to merge 1 commit into
base: go-main
Choose a base branch
from

Conversation

zhengyangfeng00
Copy link

@zhengyangfeng00 zhengyangfeng00 commented Sep 13, 2024

Context

This PR reproduces a state verification issue.

The test data state_proof_32840.json and state_proof_52648.json are the json payload returned from

https://api-devnet.lagrange.dev/batche s/state-proofs?batch_number=32840&chain_id=11155420

and

https://api-devnet.lagrange.dev/batche s/state-proofs?batch_number=52648&chain_id=11155420

In the test, we constructed two StateProof objects from the two batches, and call the VerifyAggregatedSignature method. It shows that the verification for batch number 32840 passed while it failed for 52648.

Here is the test output:

❯ go test -v
=== RUN   TestStateProofVerifyAggregatedSignature
=== RUN   TestStateProofVerifyAggregatedSignature/testdata/state_proof_32840.json
=== RUN   TestStateProofVerifyAggregatedSignature/testdata/state_proof_52648.json
    verify_test.go:39: aggregated signature verification failed
--- FAIL: TestStateProofVerifyAggregatedSignature (0.01s)
    --- PASS: TestStateProofVerifyAggregatedSignature/testdata/state_proof_32840.json (0.00s)
    --- FAIL: TestStateProofVerifyAggregatedSignature/testdata/state_proof_52648.json (0.00s)
FAIL
exit status 1
FAIL    github.com/Lagrange-Labs/lsc-state-verifier/stateproof  0.600s

I think there might be some issue on how newer version of Lagrange generates the signature.


Reviewers

@zhengyangfeng00 zhengyangfeng00 requested a review from a team as a code owner September 13, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant