Simple SELECT Queries Without Aggregation Functions #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: allow for either aggregation-only or tabular-only queries
nicholas-mainardi
changed the title
This PR introduces a circuit to expose the results of simple `SELECT` queries without aggregation functions, avoiding the need to build a results tree.
delehef
reviewed
Oct 31, 2024
| @@ -126,121 +290,168 @@ impl< | |||
| preprocessing_proof: Vec<u8>, | |||
| query_bounds: &QueryBounds, | |||
| placeholders: &Placeholders, | |||
| placeholder_hash_ids: [PlaceholderId; NUM_PLACEHOLDERS_HASHED], | |||
| predicate_operations: &[BasicOperation], | |||
| results_structure: &ResultStructure, | |||
There was a problem hiding this comment.
Please fix the out-of-date docstring.
There was a problem hiding this comment.
Done in commit 3644f30
delehef
force-pushed
the
feat/tabular-queries
branch
from
a966485
to
5483d50
Compare
delehef
force-pushed
the
feat/tabular-queries
branch
from
8631114
to
5bb0490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support for simple
SELECTqueries without aggregation functions