feat: update DB creation circuits for generic extraction (Part 2) #393
Conversation
silathdiir
force-pushed
the
generic-extraction-tree-creation
branch
from
b5a75ac to
8515c8e
Compare
silathdiir
force-pushed
the
generic-extraction-tree-creation
branch
from
0257177 to
7f9cb61
Compare
silathdiir
changed the title
silathdiir
changed the title
verifiable-db/src/cells_tree/mod.rs
Outdated
|
|
||
| let cell = CellWire::new(b); | ||
| let values_digest = cell.split_values_digest(b); | ||
| let metadata_digest = cell.split_metadata_digest(b); |
There was a problem hiding this comment.
Why not using directly split_and_accumulate methods?
There was a problem hiding this comment.
Fixed in commit ca0a971.
| .chain(empty_hash.elements) | ||
| .chain(iter::once(cell.identifier)) | ||
| let metadata_digests = cell.split_metadata_digest(b); | ||
| let values_digests = cell.split_values_digest(b); |
There was a problem hiding this comment.
Same as above: why not using split_and_accumulate?
There was a problem hiding this comment.
Fixed in commit ca0a971.
There was a problem hiding this comment.
Seems to me that on this file there were no changes in that commit? Only the other related comments seems to be addressed, no?
There was a problem hiding this comment.
Sorry, I missed this fix, just commit in e37e98e.
Co-authored-by: nicholas-mainardi <[email protected]>
…eric-extraction-tree-creation
| PublicInputs::new( | ||
| &hash.to_targets(), | ||
| &final_digest.to_targets(), | ||
| &digest.individual_vd.to_targets(), |
| PublicInputs::new( | ||
| &node_hash, | ||
| &final_digest.to_targets(), | ||
| &digest.individual_vd.to_targets(), |
| @@ -69,6 +69,8 @@ impl TestContext { | |||
| cell.identifier(), | |||
| cell.value(), | |||
| column.multiplier, | |||
| // TODO: Check mpt_metadata = cell.hash? | |||
| HashOut::rand(), | |||
There was a problem hiding this comment.
I don't think we need to check it now because it will be invalid otherwise ?
There was a problem hiding this comment.
Yes, it's wrong comment, the mpt_metadata parameter is deleted in PR #399.
…eric-extraction-tree-creation
…eric-extraction-tree-creation
…eric-extraction-tree-creation
Related section Merkle Tree Creation in Generic Extraction document