Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add generic extraction mapping of mappings to integration test (part 5, last part of generic extraction) #404

Open
wants to merge 6 commits into
base: generic-extraction-integration-test
Choose a base branch
from

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Nov 6, 2024

Summary

Add two test cases of mapping of mappings to the integration test, one is mapping of mappings to the single value entries, and another is to the Struct entries.

@silathdiir silathdiir marked this pull request as draft November 6, 2024 10:43
@silathdiir silathdiir force-pushed the generic-extraction-integration-test-mapping-of-mappings branch from fd49449 to 8c77ad4 Compare November 6, 2024 11:37
@silathdiir silathdiir changed the title [WIP] fix: add generic extraction mapping of mappings to integration test fix: add generic extraction mapping of mappings to integration test Nov 6, 2024
@silathdiir silathdiir changed the title fix: add generic extraction mapping of mappings to integration test [WIP] fix: add generic extraction mapping of mappings to integration test Nov 6, 2024
@silathdiir silathdiir changed the title [WIP] fix: add generic extraction mapping of mappings to integration test fix: add generic extraction mapping of mappings to integration test Nov 6, 2024
@silathdiir silathdiir marked this pull request as ready for review November 6, 2024 11:59
@silathdiir silathdiir force-pushed the generic-extraction-integration-test-mapping-of-mappings branch from 8c77ad4 to d0f7504 Compare November 12, 2024 13:50
@silathdiir silathdiir marked this pull request as draft November 12, 2024 13:51
@silathdiir silathdiir force-pushed the generic-extraction-integration-test-mapping-of-mappings branch 2 times, most recently from 5ac0645 to 64808ac Compare November 13, 2024 08:18
@silathdiir
Copy link
Contributor Author

silathdiir commented Nov 13, 2024

I fix the Key of MappingExtractionArgs<Key, Value> to a generic parameter, and refactor the two Mapping Of Mappings test cases to use this MappingExtractionArgs (Key is (outer_mapping_key, inner_mapping_key)).

@silathdiir silathdiir marked this pull request as ready for review November 13, 2024 08:20
@silathdiir silathdiir force-pushed the generic-extraction-integration-test-mapping-of-mappings branch 3 times, most recently from 22ea1d2 to beae7b5 Compare November 13, 2024 09:28
@silathdiir silathdiir force-pushed the generic-extraction-integration-test-mapping-of-mappings branch from beae7b5 to 29b6ddf Compare November 24, 2024 14:04
@silathdiir silathdiir changed the title fix: add generic extraction mapping of mappings to integration test fix: add generic extraction mapping of mappings to integration test (part 5, last part of generic extraction) Dec 13, 2024
assert_eq!(found_address, mapping_value);
Ok(())
}
/* TODO: Need to update, since the mapping slot value is updated.
Copy link
Contributor

@nicholas-mainardi nicholas-mainardi Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test, I placed the new value in PR #415 I am working on, you can just copy the new address from the changes to eth.rs in that PR and re-enable the test ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 5719de9, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants