-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add generic extraction mapping of mappings to integration test (part 5, last part of generic extraction) #404
base: generic-extraction-integration-test
Are you sure you want to change the base?
Conversation
fd49449
to
8c77ad4
Compare
8c77ad4
to
d0f7504
Compare
5ac0645
to
64808ac
Compare
I fix the Key of |
22ea1d2
to
beae7b5
Compare
beae7b5
to
29b6ddf
Compare
…est' into generic-extraction-integration-test-mapping-of-mappings
mp2-common/src/eth.rs
Outdated
assert_eq!(found_address, mapping_value); | ||
Ok(()) | ||
} | ||
/* TODO: Need to update, since the mapping slot value is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this test, I placed the new value in PR #415 I am working on, you can just copy the new address from the changes to eth.rs
in that PR and re-enable the test ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 5719de9, thanks.
Summary
Add two test cases of mapping of mappings to the integration test, one is mapping of mappings to the single value entries, and another is to the Struct entries.