Chore/fix clippy #407
Merged
Chore/fix clippy #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkolasg
approved these changes
Nov 12, 2024
Collaborator
nikkolasg
left a comment
nikkolasg
left a comment
There was a problem hiding this comment.
Yessss ! Thank you so much ! 🙏
Now that we can start from a "green" codebase, our OCDs will be satisfied ;)
nicholas-mainardi
approved these changes
Nov 12, 2024
Contributor
nicholas-mainardi
left a comment
nicholas-mainardi
left a comment
There was a problem hiding this comment.
LGTM! Just left a few minor comments. Thanks a lot for taking this burden
recursion-framework/src/universal_verifier_gadget/circuit_set.rs
Outdated
Show resolved
Hide resolved
recursion-framework/src/universal_verifier_gadget/circuit_set.rs
Outdated
Show resolved
Hide resolved
| pub(crate) const CONTRACT_SET_NUM_IO: usize = contract_extraction::PublicInputs::<F>::TOTAL_LEN; | ||
| pub(crate) const VALUE_SET_NUM_IO: usize = values_extraction::PublicInputs::<F>::TOTAL_LEN; | ||
| // CHORE: Remove this when relevant PR is merged | ||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
This constant could be erased if unused I think
Contributor
Author
There was a problem hiding this comment.
Okay cool, just didn't want to get rid of it if it was about to be used in a PR thats in Review.
|
|
||
| impl MergeCircuitInput { | ||
| // CHORE: Remove this when relevant PR is merged | ||
| #[allow(dead_code)] |
Contributor
There was a problem hiding this comment.
This method as well can be removed if unused
Contributor
Author
There was a problem hiding this comment.
Alright cool will do
Zyouell
force-pushed
the
chore/fix-clippy
branch
from
10ec95c to
f4e42af
Compare
Zyouell
force-pushed
the
chore/fix-clippy
branch
from
eacde4a to
b08558a
Compare
Zyouell
added a commit
that referenced
this pull request
Jan 13, 2025
This PR addresses warning produced by `cargo clippy`, it also adds an example pre-commit hook for people to install if they wish so that `cargo fmt --all -- --check` and `cargo clippy` will run every time you commit locally as well as a guide to install the hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses warning produced by
cargo clippy, it also adds an example pre-commit hook for people to install if they wish so thatcargo fmt --all -- --checkandcargo clippywill run every time you commit locally as well as a guide to install the hook.