fix: add common derives for integration
#419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
force-pushed
the
add-derives-for-dq
branch
from
fe6fe29 to
6d65d97
Compare
nicholas-mainardi
approved these changes
Dec 11, 2024
| @@ -65,7 +65,7 @@ impl<'a, C: ContextProvider> NonExistenceInput<'a, C> { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) async fn find_row_node_for_non_existence( | |||
| pub async fn find_row_node_for_non_existence( | |||
There was a problem hiding this comment.
Just curious, why do you need to make this function public to use it in DQ? In my mind everything needed for DQ should be provided by generate_chunks_and_update_tree method
There was a problem hiding this comment.
I see, let me check (seems it's used for a old DQ function for rows-tree proving), thanks.
There was a problem hiding this comment.
I tried to check the DQ code, it's also called when creating the rows inputs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.