Conversation
nikkolasg
reviewed
Feb 19, 2024
nikkolasg
reviewed
Feb 19, 2024
nikkolasg
reviewed
Feb 19, 2024
nikkolasg
reviewed
Feb 19, 2024
nikkolasg
reviewed
Feb 21, 2024
Collaborator
nikkolasg
left a comment
nikkolasg
left a comment
There was a problem hiding this comment.
Looking good !!! Looking forward to see the tests !
silathdiir
force-pushed
the
feat/block-linking
branch
from
3cffd34 to
93053c8
Compare
silathdiir
changed the title
nikkolasg
reviewed
Feb 23, 2024
Collaborator
nikkolasg
left a comment
nikkolasg
left a comment
There was a problem hiding this comment.
Well done ! A few nitpicks around organization and some comments, but should be good to merge soon imo !
Base automatically changed from
feat/storage_mpt_key_derivation
to
feat/verify_contract_proof
February 24, 2024 14:29
silathdiir
force-pushed
the
feat/block-linking
branch
from
1a2e7f1 to
875b2a0
Compare
silathdiir
changed the base branch from
feat/verify_contract_proof
to
feat/storage_mpt_key_derivation
…is linked to the specific block header.
Co-authored-by: Nicolas Gailly <[email protected]>
Co-authored-by: Nicolas Gailly <[email protected]>
nicholas-mainardi
approved these changes
Mar 2, 2024
Contributor
nicholas-mainardi
left a comment
nicholas-mainardi
left a comment
There was a problem hiding this comment.
LGTM now! Thanks for addressing all the issues. I did a commit with small changes to the block_header_decoding test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close https://github.com/Lagrange-Labs/mapreduce-plonky2/issues/32
Implement this circuit according to Linking with Block Number.
eth_getProof.