Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backpack v6 #4860

Merged
merged 614 commits into from
Jul 2, 2023
Merged

Backpack v6 #4860

merged 614 commits into from
Jul 2, 2023

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Dec 29, 2022

This is the working branch for Backpack v6. We'll make sure to note here everything we merge into it, and any breaking changes we introduce.

Already merged into this branch:

To be merged, before the final release:

  • main into main-without-assets
  • main-without-assets into main
  • this branch into main

Breaking changes

  1. No longer need public/packages, you can delete it using rm -rf public/packages && php artisan backpack:filemanager:install

  2. Change base view files - see [6.x][WIP] Bassets 🐶 #4815 for differences.

@tabacitu tabacitu self-assigned this Dec 29, 2022
@tabacitu tabacitu changed the base branch from main to main-without-assets January 4, 2023 10:12
src/config/backpack/base.php Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/resources/views/crud/columns/range.blade.php Outdated Show resolved Hide resolved
src/resources/views/base/inc/scripts.blade.php Outdated Show resolved Hide resolved
src/resources/views/base/inc/head.blade.php Outdated Show resolved Hide resolved
src/resources/views/base/inc/head.blade.php Outdated Show resolved Hide resolved
@tabacitu tabacitu assigned promatik and unassigned tabacitu Feb 21, 2023
src/ViewNamespaces.php Outdated Show resolved Hide resolved
@tabacitu tabacitu assigned tabacitu and unassigned promatik Mar 21, 2023
@tabacitu
Copy link
Member Author

I have great news! 🥁🥁🥁 We now have stable branches for v6, for all our main packages!

We now have:

I'll give them all another look tomorrow. I might have missed some stuff. But I'm super super excited... we can now merge stuff into v6, add new features, etc. Woohooo 🎉

@scrutinizer-notifier
Copy link

A new inspection was created.

tabacitu and others added 12 commits April 25, 2023 15:59
Add `withFiles()` functionality to CRUD fields
[ci skip] [skip ci]
[ci skip] [skip ci]
…ck/CRUD into upload-validation

# Conflicts:
#	src/app/Library/Validation/Rules/ValidFileArray.php
#	src/app/Library/Validation/Rules/ValidNestedArray.php
#	src/app/Library/Validation/Rules/ValidRepeatable.php
#	src/app/Library/Validation/Rules/ValidUpload.php
[ci skip] [skip ci]
Copy link
Member Author

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to require v6.x-dev versions when we install add-ons - they all have versions launched.

src/app/Console/Commands/Addons/RequireDevTools.php Outdated Show resolved Hide resolved
src/app/Console/Commands/Addons/RequireEditableColumns.php Outdated Show resolved Hide resolved
src/app/Console/Commands/Addons/RequirePro.php Outdated Show resolved Hide resolved
src/app/Console/Commands/Install.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@tabacitu tabacitu changed the title [WIP] Backpack v6 Backpack v6 Jul 2, 2023
Copy link
Member Author

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went through all files, did a review. Looks pretty good (except for the parts that don't 😅). Added issues along the way. Noted documentation problems in Laravel-Backpack/docs#450

I think from a code perspective... this is good to go 😱

Base automatically changed from main-without-assets to main July 2, 2023 15:02
@tabacitu tabacitu merged commit 7c0f051 into main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

9 participants