Clean unused files, remove need to publish views#67
Closed
pxpm wants to merge 2 commits intonamed-assetsfrom
Closed
Clean unused files, remove need to publish views#67pxpm wants to merge 2 commits intonamed-assetsfrom
pxpm wants to merge 2 commits intonamed-assetsfrom
Conversation
Merged
Contributor
Author
|
closed in favor of #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
We had a lot of unused files.
Publishing the views was mandatory.
AFTER - What is happening after this PR?
Unused files were removed from this repo.
Views don't need to be published anymore (but they can optionally be)
Is it a breaking change or non-breaking change?
100% breaking, but we are launching a major version, so it should be ok.
If @tabacitu agree with this, I will just write the upgrade guide in the readme.
It should be as simple as
removing the published views, if no customization needed, no need to re-publish them. If customizing views is required, republish them again and re-apply the customizations.