-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable Vagrant Box for Builds #779
base: master
Are you sure you want to change the base?
Conversation
Because portability is king™.
Hi, awesome job, but would it be possible to push it to dev branch instead? Also the Electron app is here now https://github.com/Laverna/laverna-desktop |
I can rebase on dev branch, but can you please update your documentation to point to Laverna Desktop as a separate repository? I honestly don't know what is what anymore, I've had quite a hard time getting this together. |
Additionally, there are no releases listed on Laverna Desktop in that repository so it appears I'm still on my own to get things building in a predictable way. I'm happy to contribute and help, but I'm very confused as to how this project is organized. |
Sorry for confusion and late response. Long story short, on Laverna/laverna-desktop we keep just Electron related stuff. On Laverna/laverna we keep the core app. Instructions how to build laverna-desktop: https://github.com/Laverna/laverna-desktop#development |
@wwebfor should I contribute this work to that other repository? |
@naftulikay yes, if possible. |
I will be submitting a pull request soon to Laverna Desktop. I am trying to build Laverna locally first so I can test that the package actually works over there. |
FWIW this project does not build on either Node 6 (stable) or Node 8 (latest) within this Vagrant box. We can merge this pull request, but until the issues are resolved, this won't change anything. Attached are logs for both versions of Node. |
Because portability is king™.
WARNING
This is currently broken, due in part to some weird errors I get during building:
npm install
gulp build
Here is my
npm-debug.log
: npm-debug.log.zipNot sure why it's not building. I would like to build the Electron app and package it for various Linux distributions.